-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spotless] Applying Google Code Format for core/src/main files #2 #321
[Spotless] Applying Google Code Format for core/src/main files #2 #321
Conversation
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
Signed-off-by: Mitchell Gale <[email protected]>
ead2e07
to
d00dc4d
Compare
Codecov Report
@@ Coverage Diff @@
## integ/sl_GoogleJavaFormat2 #321 +/- ##
================================================================
+ Coverage 97.42% 97.50% +0.08%
- Complexity 4647 4659 +12
================================================================
Files 408 408
Lines 11526 11912 +386
Branches 839 835 -4
================================================================
+ Hits 11229 11615 +386
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Mitchell Gale <[email protected]>
public interface ExecutionEngine { | ||
|
||
/** | ||
* Execute physical plan and call back response listener. | ||
* Todo. deprecated this interface after finalize {@link ExecutionContext}. | ||
* Execute physical plan and call back response listener. Todo. deprecated this interface after |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yury-Fridlyand was this one of your comments? Do we need to address this?
* Execute the {@link UnresolvedPlan}, using {@link ResponseListener} to get response. | ||
* Todo. deprecated this interface after finalize {@link PlanContext}. | ||
* Execute the {@link UnresolvedPlan}, using {@link ResponseListener} to get response. Todo. | ||
* deprecated this interface after finalize {@link PlanContext}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yury-Fridlyand same here
ad948b8
into
integ/sl_GoogleJavaFormat2
Description
This PR applies Spotless on Java code for:
core/src/main/java/org/opensearch/sql/exception
core/src/main/java/org/opensearch/sql/executor
core/src/main/java/org/opensearch/sql/expression
core/src/main/java/org/opensearch/sql/monitor
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.